prioritize tracks with stored analysis in analysis queue

[mixxxbot]

Reported by: daschuer
Date: 2012-12-08T15:09:15Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1087995
Attachments: prioritize_analysis.patch

---

Currently, If you load a already analysed track to a deck, the waveform is displayed after a possible running analysis on an other track is finished.

I will prepare a patch which instantly loads the analysis data for already processed tracks.

[mixxxbot]

Commented by: daschuer
Date: 2012-12-10T20:10:30Z
Attachments: prioritize_analysis.patch

---

the attached patch works like described. It it includes the changes from Bug #⁠1088071.
It was created against lp:mixxx/1.11 #⁠3590

[mixxxbot]

Commented by: rryan
Date: 2012-12-11T07:23:38Z

---

Hm, my only worry is that we throw away partially completed analysis of a
track whenever you load another track that has pre-calculated analyses.

On Mon, Dec 10, 2012 at 3:10 PM, Daniel Schürmann <
<email address hidden>> wrote:

the attached patch works like described. It it includes the changes from
Bug #⁠1088071.
It was created against lp:mixxx/1.11 #⁠3590

** Patch added: "prioritize_analysis.patch"

https://bugs.launchpad.net/mixxx/+bug/1087995/+attachment/3456530/+files/prioritize_analysis.patch

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/1087995

Title:
prioritize tracks with stored analysis in analysis queue

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1087995/+subscriptions

[mixxxbot]

Commented by: daschuer
Date: 2012-12-11T10:50:20Z

---

Hi RJ,

Thank you fro review!

Hm, my only worry is that we throw away partially completed analysis of a
track whenever you load another track that has pre-calculated analyses.

In one of my first version this was the case but now I have made it const 
virtual bool loadStored(TrackPointer tio) const = 0;
so a running analysis is not disturbed. 

Commit to lp:mixxx/1.11?

[mixxxbot]

Commented by: rryan
Date: 2012-12-13T06:51:31Z

---

Thanks -- I didn't read closely enough.

In most of the analyzers from initialize() you call loadStored() and return false if the track initialized. I don't see this in AnalyserBeats. Is there a particular reason for that?

Otherwise looks good to commit. The patch also includes the fix from Bug #⁠1088071, right?

[mixxxbot]

Commented by: rryan
Date: 2012-12-13T06:52:21Z

---

I plan to tag beta2 tomorrow and would definitely like this to be included so we can get it tested. Thanks!

[mixxxbot]

Commented by: daschuer
Date: 2012-12-13T23:23:33Z

---

Committed to lp:mixxx/1.11 #⁠3626.

[mixxxbot]

Issue closed with status Fix Released.