Add control for AutoDJ status

[mixxxbot]

Reported by: wagnerflo
Date: 2013-04-08T09:19:53Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1166095
Tags: autodj
Attachments: autodj_enabled.patch

---

Yesterday I looked at adding a binding in my MIDI controller mapping for AutoDJ. I've found the "toggle_autodj" control which most of the time will turn AutoDJ on/off if used with setValue (not always: if there are no songs in the AutoDJ queue it will do nothing).

But there seems to be no control that signals AutoDJ status and thus no way to use engine.connectControl to get notified (for binding an LED on the controller, for example). That would be important because AutoDJ will turn of by itself when it runs out of songs. That would be nice to display on the controller.

[mixxxbot]

Commented by: daschuer
Date: 2013-04-09T19:29:31Z
Attachments: autodj_enabled.patch

---

The attached patch introduces a new Control Object as toggle button similar to "[Channel1]", "play":
"[AutoDJ]", "enabled"

We can consider to entirely remove "toggle_autodj" later.

[mixxxbot]

Commented by: wagnerflo
Date: 2013-04-10T06:57:41Z

---

This is great! I'll test the patch as soon as possible, which sadly won't be before the weekend.

[mixxxbot]

Commented by: rryan
Date: 2013-04-10T13:57:54Z

---

Hey Daniel -- the patch looks good except I think the

+    connect(m_pCOEnabledAutoDJ, SIGNAL(valueChanged(double)),
+            this, SLOT(enableAutoDJCo(double)));

should be to the COTM not the CO.

[mixxxbot]

Commented by: daschuer
Date: 2013-04-10T15:11:24Z

---

Thank your RJ.

Yes, I was not sure.

What do think about removing the "toggle_autodj"?
If someone is already using it, is easy to change.
Where should I commit it?

[mixxxbot]

Commented by: esbrandt
Date: 2013-04-12T08:06:53Z

---

If this change goes into 1.11, let's not forget to adjust the keyboard mappings as we currently use "toggle_autodj" there.

[mixxxbot]

Commented by: daschuer
Date: 2013-04-12T09:12:28Z

---

I am pro committing to 1.11.1.
Currently it supports both control objects, but I am in favor to remove "toggle_autodj" because it is redundant and it was in no release version yet.

So I will change existing mappings, learning wizards and keyboard shortcuts.

What do you think?

[mixxxbot]

Commented by: rryan
Date: 2013-04-12T14:23:59Z

---

I think toggle should stay -- otherwise how can you toggle AutoDJ with a
single button?

On Fri, Apr 12, 2013 at 5:12 AM, Daniel Schürmann <
<email address hidden>> wrote:

I am pro committing to 1.11.1.
Currently it supports both control objects, but I am in favor to remove
"toggle_autodj" because it is redundant and it was in no release version
yet.

So I will change existing mappings, learning wizards and keyboard
shortcuts.

What do you think?

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/1166095

Title:
Add control for AutoDJ status

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1166095/+subscriptions

[mixxxbot]

Commented by: wagnerflo
Date: 2013-04-12T14:52:47Z

---

By setting it to the negation of the value the control currently has? In Midi-/Javascript terms "engine.setValue(group, name, !engine.getValue(group, name))".

[mixxxbot]

Commented by: daschuer
Date: 2013-04-12T15:32:05Z

---

Committed to lp:mixxx/1.11 revision 3816 as proposed in #⁠6

[mixxxbot]

Commented by: daschuer
Date: 2013-04-12T15:46:38Z

---

Oh I am sorry, I have not read #⁠7 and #⁠8 before #⁠9.

"[AutoDJ]", "enabled" behaves exactly like "toggle_autodj" when setting from midi mapping or keyboard, because it has setButtonMode(ControlPushButton::TOGGLE)
The only difference is that it reflects the current "enabled" state of the AutoDJ.
and when you use setValue from script there is no toggle function.
Florians example is correct.

So it was save to me to delete toggle_autodj.

[mixxxbot]

Commented by: rryan
Date: 2013-04-12T16:52:55Z

---

Gotcha -- I misunderstood. Thanks!

On Fri, Apr 12, 2013 at 11:46 AM, Daniel Schürmann <
<email address hidden>> wrote:

Oh I am sorry, I have not read #⁠7 and #⁠8 before #⁠9.

"[AutoDJ]", "enabled" behaves exactly like "toggle_autodj" when setting
from midi mapping or keyboard, because it has
setButtonMode(ControlPushButton::TOGGLE)
The only difference is that it reflects the current "enabled" state of the
AutoDJ.
and when you use setValue from script there is no toggle function.
Florians example is correct.

So it was save to me to delete toggle_autodj.

--
You received this bug notification because you are a member of Mixxx
Development Team, which is subscribed to Mixxx.
https://bugs.launchpad.net/bugs/1166095

Title:
Add control for AutoDJ status

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1166095/+subscriptions

[mixxxbot]

Commented by: wagnerflo
Date: 2013-04-13T21:31:29Z

---

I've tested revision 3818 of the mixxx/1.11 branch in regard to this functionality and found it to be working as expected!

Thanks again.

[mixxxbot]

Commented by: daschuer
Date: 2013-04-13T23:35:05Z

---

Thank you for re-testing!

[mixxxbot]

Issue closed with status Fix Released.