Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Next" and "Previous" don't save changes to track metadata #9323

Open
mixxxbot opened this issue Aug 23, 2022 · 7 comments
Open

"Next" and "Previous" don't save changes to track metadata #9323

mixxxbot opened this issue Aug 23, 2022 · 7 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: jfrench
Date: 2018-06-01T11:31:06Z
Status: Confirmed
Importance: Wishlist
Launchpad Issue: lp1774625


When editing track metadata in Mixxx library, hitting "Next" and "Previous" buttons should save the track metadata before moving to edit the next track. Instead, I have to hit "Apply" every time, before moving to the next track.

Ubuntu 16.04 LTS
Mixxx 2.1.0 x64

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2018-06-01T11:50:37Z


I also always stumble about this. On the other hand saving metadata implicitly while navigating is dangerous.

Maybe add a checkbox for enabling implicit saving during an editing session? This setting should be visible directly in the dialog and not buried deep in the preferences. It needs to be re-enabled once the dialog has been closed.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2018-06-01T12:07:38Z


I think it would be better to ask the user when the next/previous buttons are pressed than bury the option in the preferences (why would a user think to look there when editing metadata?).

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2018-06-01T12:25:24Z


I don't propose a preference setting, that context would be too broad.

Confirming a dialog box each time after pressing Next/Previous is also inconvenient when editing multiple items in a row. Maybe the checkbox can be integrated into this confirmation dialog to enable the implicit "Apply" action for all subsequent Next/Previous interactions until the properties dialog is closed.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2018-06-01T12:51:08Z


The current layout implies to me, that I can edit as many tracks I like and finally press cancel or apply all. So we should either do it exact like that and keep a list of cloned tracks, or we need to rearrange the buttons like this draft:

[Apply and Previous] [Apply and Next] [Apply and Close] [Restore] [Cancel]

or

------- Apply Changes ----- ------- Reject Changes -----
[Previous] [Next] [Close] [Restore] [Cancel]

@mixxxbot
Copy link
Collaborator Author

Commented by: jfrench
Date: 2018-06-05T16:29:48Z


Interesting...having been a Mac user for many years, in iTunes it's
standard behavior that clicking "Next" or "Previous" saves the changes. I
don't quite understand the logic of making changes to metadata, then moving
to another track and it NOT saving. Why would anyone want to do that?

On Fri, Jun 1, 2018 at 7:51 AM, Daniel Schürmann <

wrote:

The current layout implies to me, that I can edit as many tracks I like
and finally press cancel or apply all. So we should either do it exact
like that and keep a list of cloned tracks, or we need to rearrange the
buttons like this draft:

[Apply and Previous] [Apply and Next] [Apply and Close] [Restore]
[Cancel]

or

------- Apply Changes ----- ------- Reject Changes -----
[Previous] [Next] [Close] [Restore] [Cancel]

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1774625

Title:
"Next" and "Previous" don't save changes to track metadata

Status in Mixxx:
Confirmed

Bug description:
When editing track metadata in Mixxx library, hitting "Next" and
"Previous" buttons should save the track metadata before moving to
edit the next track. Instead, I have to hit "Apply" every time, before
moving to the next track.

Ubuntu 16.04 LTS
Mixxx 2.1.0 x64

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1774625/+subscriptions

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2018-06-05T18:57:32Z


The user might have messed up things and want to undo it. We should at least keep an option for this.

@mixxxbot
Copy link
Collaborator Author

Commented by: jfrench
Date: 2018-06-09T03:39:33Z


But that's why you can click "cancel." If you navigate off the screen with
"ok / apply" or "next / previous," it should save unless you tell it
otherwise IMO.

On Tue, Jun 5, 2018, 2:10 PM Daniel Schürmann <email address hidden>
wrote:

The user might have messed up things and want to undo it. We should at
least keep an option for this.

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1774625

Title:
"Next" and "Previous" don't save changes to track metadata

Status in Mixxx:
Confirmed

Bug description:
When editing track metadata in Mixxx library, hitting "Next" and
"Previous" buttons should save the track metadata before moving to
edit the next track. Instead, I have to hit "Apply" every time, before
moving to the next track.

Ubuntu 16.04 LTS
Mixxx 2.1.0 x64

To manage notifications about this bug go to:
https://bugs.launchpad.net/mixxx/+bug/1774625/+subscriptions

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant