-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cue preview #3268
fix cue preview #3268
Conversation
It seems to work, my short manual test was unable to reproduce the issue. The play button does not light up during previewing. I don't really care about it, but maybe someone would like to keep that? |
Ah, I see. |
Shall we merge this anyway? I'd consider the play button issue less severe than the broken previewing. |
Yes, we can go in small steps. |
I can't reproduce the play button issue. Does it always happen? With this branch or merged to main? |
Yes, always. Using this branch directly. |
This is actually an issue with the 2.3 branch. |
Ok |
You mean: the play doesn't necessarily need to be lit while previewing. |
Cue preview can latch undesired, due to a race condition.
This is fixed here (lhttps://bugs.launchpad.net/mixxx/+bug/1903002)