cue preview does not work when jumping

[mixxxbot]

Reported by: daschuer
Date: 2020-11-05T07:31:39Z
Status: Confirmed
Importance: High
Launchpad Issue: lp1903002

---

When pressing a loop cue button the track seeks to the loop and starts playing.
When releasing the button it continues "sometimes" to play.
I have the impression that it only happnes if the track have been seeked forward to the loop.
This was tested with LateNigt and Shade skin and current main branch.

[mixxxbot]

Commented by: Holzhaus
Date: 2020-11-05T11:08:10Z

---

Looks like sometimes m_iCurrentlyPreviewingHotcues is not incremented properly.

 void CueControl::hotcueActivatePreview(HotcueControl* pControl, double value) {
+    qWarning() << "CueControl::hotcueActivatePreview" << value << m_iCurrentlyPreviewingHotcues;
     QMutexLocker lock(&m_mutex);
     if (!m_pLoadedTrack) {
         return;

warning [Main] CueControl::hotcueActivatePreview 1 0
warning [Main] CueControl::hotcueActivatePreview 0 1
warning [Main] CueControl::hotcueActivatePreview 1 0
warning [Main] CueControl::hotcueActivatePreview 0 1
warning [Main] CueControl::hotcueActivatePreview 1 0
warning [Main] CueControl::hotcueActivatePreview 0 1
warning [Main] CueControl::hotcueActivatePreview 1 0
warning [Main] CueControl::hotcueActivatePreview 0 0

[mixxxbot]

Commented by: Holzhaus
Date: 2020-11-05T11:27:15Z

---

Found a pretty easy way to reproduce:

1. Start previewing a hotcue using the mouse
2. Start previewing the same hotcue using the keyboard or a controller
3. Release both in no particular order

[mixxxbot]

Commented by: Holzhaus
Date: 2020-11-05T11:32:24Z

---

Please test #3267.

[mixxxbot]

Commented by: Holzhaus
Date: 2020-11-05T14:35:55Z

---

I can also reproduce the issue with regular cues on the 2.3 branch, so has not been caused by PR #⁠2194. Nonetheless, PR #⁠3267 fixes an issue introduced by the saved loops feature and should be merged anyway.

[mixxxbot]

Commented by: Holzhaus
Date: 2020-11-05T14:51:00Z

---

Here's a little Demo on the 2.3 branch: https://www.youtube.com/watch?v=lyUa2JhRRps

[mixxxbot]

Commented by: daschuer
Date: 2020-11-05T21:38:50Z

---

One Part of the issue is fixed here:
#3268