Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors for 1d models #121

Merged
merged 8 commits into from
Nov 15, 2021
Merged

Errors for 1d models #121

merged 8 commits into from
Nov 15, 2021

Conversation

mj-will
Copy link
Owner

@mj-will mj-will commented Oct 26, 2021

This PR adds explicit checks to catch cases where the model is one-dimensional or a one-dimensional input is being passed to the normalising flow.

@mj-will mj-will added the enhancement New feature or request label Oct 26, 2021
@mj-will mj-will added this to the v0.3.3 milestone Oct 26, 2021
@mj-will mj-will modified the milestones: v0.3.3, v0.4.0 Nov 4, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #121 (ef23b95) into main (67fe6e3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   94.94%   95.00%   +0.05%     
==========================================
  Files          39       39              
  Lines        3583     3626      +43     
==========================================
+ Hits         3402     3445      +43     
  Misses        181      181              
Flag Coverage Δ
unittests 95.00% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nessai/flows/nsf.py 97.05% <100.00%> (+0.18%) ⬆️
nessai/flows/realnvp.py 100.00% <100.00%> (ø)
nessai/model.py 100.00% <100.00%> (ø)
nessai/reparameterisations.py 91.34% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67fe6e3...ef23b95. Read the comment docs.

@mj-will mj-will marked this pull request as ready for review November 15, 2021 09:58
@mj-will mj-will merged commit bc3eec0 into main Nov 15, 2021
@mj-will mj-will deleted the errors-for-1d-models branch November 17, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants