Use GW reparameterisations by default #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
GWFlowProposal
will not use the included reparameterisations ifreparameterisations=None
. This means that running the sampler with the correct proposal doesn't guarantee the correct reparameterisations.This PR adds an option to force FlowProposal or any class that inherits from it to use the default reparameterisations even if
reparameterisations=None
and adds an attribute that defines the default behaviour.Changes
use_default_reparameterisations
to FlowProposal this defaults toFalse
and can be overridden by child classes.use_default_reparameterisations=None
to the inputs ofFlowProposal
. When set toNone
the default for the class is used. Setting it toTrue
orFalse
overrides the default behaviour.