Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove borders on codeblocks #116

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Sep 8, 2023

Part of #115

The default styling of the markdown preview applies the widgets.border color to codeblocks in the markdown preview.

2023-09-08_14-34

This PR just removes that border to match the fact that GitHub does not add borders to these blocks

Testing

  • Add a color customization to your settings
    "workbench.colorCustomizations": {
        "widget.border": "#000"
    }
  • Create a markdown file with a codeblock containing anything
  • Check that there is no border on this branch

@jjspace
Copy link
Contributor Author

jjspace commented Sep 21, 2023

Just bumping this PR, @mjbvz can you take a quick look at this please? 🙏

@mjbvz mjbvz merged commit f7bc10c into mjbvz:master Sep 21, 2023
@mjbvz
Copy link
Owner

mjbvz commented Sep 21, 2023

Thanks!

@jjspace jjspace deleted the no-codeblock-borders branch September 21, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants