Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds product id support for SP mini 3/L6 OEM (0x7549) #747

Closed
wants to merge 1 commit into from
Closed

Adds product id support for SP mini 3/L6 OEM (0x7549) #747

wants to merge 1 commit into from

Conversation

snowyu
Copy link

@snowyu snowyu commented Feb 5, 2023

Context

Adds product id support for SP mini 3(L6) OEM (0x7549)

Proposed change

Just ID added.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • The code follows the Zen of Python.
  • I am creating the Pull Request against the correct branch.
  • Documentation added/updated.

@snowyu snowyu changed the title Adds support for SP mini 3/L6 OEM (0x7549) Adds product id support for SP mini 3/L6 OEM (0x7549) Feb 5, 2023
@felipediel felipediel mentioned this pull request Feb 17, 2023
Merged
13 tasks
@felipediel
Copy link
Collaborator

felipediel commented Feb 17, 2023 •
edited
Loading

Thank you! Merged into new_product_ids with #753.

@felipediel felipediel closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snowyu @felipediel