Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing qb game log stats #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add missing qb game log stats #60

wants to merge 1 commit into from

Conversation

O1ahmad
Copy link

@O1ahmad O1ahmad commented May 21, 2024 •
edited
Loading

  • add remaining quarterback game log stats (continues to exclude those which are capable of being calculated by other stats like pass/run yard averages)
  • fix failing tests a part of existing test suite

@O1ahmad
Copy link
Author

O1ahmad commented Jun 4, 2024 •
edited
Loading

TODO: I'm planning on refactoring the table_rows[i].find('td', {'data-stat': '<insert>'}).text) into a separate method to avoid the redundancy and also add additional error checking. @mjk2244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@O1ahmad @0xOI