Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreceived genuine emails due to extra space after MAIL FROM: #101

Closed
Fell opened this issue Dec 7, 2023 · 3 comments
Closed

Unreceived genuine emails due to extra space after MAIL FROM: #101

Fell opened this issue Dec 7, 2023 · 3 comments

Comments

@Fell
Copy link

Fell commented Dec 7, 2023

I have not received an email about a flight schedule change due to this:

bad syntax: expected "<" (remaining " <no-reply@koreanair.com>")

Now, I know this issue has come up before, but in different ways.

As @mjl- mentioned in https://github.com/mjl-/mox/issues/51#issuecomment-1656138445 the extra space after MAIL FROM: is not permitted in SMTP.

Mox doesn't allow it, as it is normally a sign of spammers with a sloppy SMTP implementation.

However, it appears that airlines, often infamous for their outdated IT infrastructre, also use sloppy SMTP implementations. This is a problem. If I didn't also receive an SMS notifiaction, I would have never known about this schedule change.

I fully understand that Mox wants to only use correct SMTP and prevent as much spam as possible, but I think the implementation needs to be less strict here.

Note: If you want to poke (or blame) the SMTP server in question, it was tc03.koreanair.com or 211.218.145.102.
Edit: Doesn't look like there is an actual SMTP server behind that address.

@mjl-
Copy link
Owner

mjl- commented Dec 10, 2023

Hi Fell, thanks for raising this. It's indeed bad if this issue causes mail not to be delivered, I'm afraid sloppy SMTP implementations will be a fact of life...
I'll make the change to accept the additional space soon.

mjl- added a commit that referenced this issue Dec 11, 2023
…d for SMTP delivery (unless in pedantic mode)

we already allowed it for (authenticated) SMTP submission. it turns out also
legitimate senders can use this invalid syntax to deliver messages.

for issue #101 by Fell, thanks for reporting & explaining!
@Fell
Copy link
Author

Fell commented Dec 13, 2023

I can confirm that epicgames.com is also guilty of the extra space, which is especially problematic because I can't receive their 2FA emails.

I'm installing from source to confirm the fix now.

@Fell
Copy link
Author

Fell commented Dec 13, 2023

Can confirm: After installing from the latest commit, previously unreceived emails are now received. 👍🏻

@Fell Fell closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants