Fixed syntax/linker issues when using Microsoft Visual C++ Compiler for Python 2.7 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiler for Python 2.7. - radix.c: Moved variables to the top of the radix_search_node function. - radix.h: Ensured code gets linked with ws2_32.lib when _MSC_VER is defined.
Compiler for Python 2.7 This is an issue when using 32bit instead of 64bit.
|
Unfortunately I don't have access to a Windows box anymore and I haven't quite gotten the AppVeyor builder to work yet, so I'll have to trust the little output from AppVeyor and your judgement on getting it to work. So, thanks! Please let me know if you have any other problems, I'll take another stab at getting AppVeyor to work when I can. |
|
Release as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues when doing a pip install py-radix or manually compiling the C Extensions on a Windows machine using python setup.py build. This commit solves that issue when using MSVC++ as a target compiler.
Edit: with Python 2.7.12 64bit.
Please review.
It seems 32bit will have the same issues and requires the above merge + doing something with the inet_ntop reference in radix/_radix/radix.h.