Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix license and include tests in sdist #37

Closed
wants to merge 3 commits into from
Closed

Fix license and include tests in sdist #37

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 25, 2018

  • As the BSD license is more restrictive than ISC, specify the latest. Also, ISC and BSD are not the same.
  • Include the tests in source tarballs (sdist). This does not affect the binary packages (bdist_wheel). But for those who download the source (for redistribution e.g.), the test are good to check the functionality.
  • and remove unused code in setup.py for < 2.7, add a minimal python version

@coveralls
Copy link

coveralls commented Jan 25, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 90.33% when pulling 34b4da2 on wagner-certat:fix-pack into 52d70b0 on mjschultz:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.33% when pulling ec5c9d0 on wagner-certat:fix-pack into 52d70b0 on mjschultz:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.33% when pulling ec5c9d0 on wagner-certat:fix-pack into 52d70b0 on mjschultz:master.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@coveralls