Add support for text formula cells. - Prevent "Cannot get a numeric value from a text formula cell" #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evaluate formula cell prior to date formatted check to prevent "Cannot get a numeric value from a text formula cell" exception.
|
+1 |
This was referenced Mar 15, 2015
Closed
|
Thanks a lot for the contribution, it was accepted with issue #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluate formula cell prior to date formatted check to prevent "Cannot get a numeric value from a text formula cell" exception.
The modification is in speadsheet.clj. The formulae integration test has been updated to check for text formulas.
The read-cell multi method for Cell/CELL_TYPE_FORMULA has been modified to first evaluate the formula, then inspect the type of the CellValue object returned and determine whether a date is present else boolean, number or string.