Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.4.0 #14

Closed
wants to merge 4 commits into from
Closed

V1.4.0 #14

wants to merge 4 commits into from

Conversation

mkalioby
Copy link
Owner

No description provided.

ashokdelphia and others added 4 commits June 17, 2023 12:47
@ashokdelphia
Show user-supplied name during deletion (without an HTML injection) (#11
4fe746e 
)

* Pass the user-supplied name for the deletion confirmation.

It doesn't appear that key_type is set at all, so renders as the empty string.

* Set the deletion confirmation as text, not HTML.

Otherwise, passing the user-supplied string allows for HTML injection.
@ashokdelphia
Tweak grammar for the empty-list case. (#10)
d3d0e3c
@ashokdelphia
Avoid hard-coding the username field name (#8)
5653adf 
* Avoid hard-coding the username field name.

This is provided by Django's AbstractBaseUser class, which allows setting a different field name using USERNAME_FIELD.

* Use the Django helper to get the username.

I'm not entirely sure when the base username is set in the session, but this should have the same behaviour as before, but without hard-coding the username field name.
@mkalioby
Updated CHANGELOG and README
b5b72e8
@mkalioby mkalioby closed this Jun 17, 2023
@mkalioby mkalioby changed the title V1.3.0 V1.4.0 Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkalioby @ashokdelphia