Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.3.0 #28

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

V1.3.0 #28

wants to merge 3 commits into from

Conversation

mkalioby
Copy link
Owner

@mkalioby mkalioby commented Nov 9, 2023

Add Support to Django 5.0 and Python3.12

@rafaelurben
Copy link

rafaelurben commented Sep 3, 2024 •
edited
Loading

@mkalioby I think using assertEqual directly (as done in #29) instead of aliasing assertEquals to assertEqual makes more sense. As far as I can see, assertEquals has never been officially documented and as such using only assertEqual should not break anything in any version.

@mkalioby
Copy link
Owner Author

mkalioby commented Sep 3, 2024

It breaks on django v5.0

@rafaelurben
Copy link

@mkalioby I have just noticed that there was a typo in my last comment. I meant just using assertEqual (not assertEquals) should not break anything. I apologize for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grigorov grigorov grigorov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkalioby @rafaelurben @grigorov