New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

float32 type size error #16

Closed

srivathsanmurali opened this issue Sep 26, 2016 · 2 comments

srivathsanmurali commented Sep 26, 2016

Hi,
In PlyFile.cpp: ply_type_sizes,

float 32 is set to be 8 bytes
an entry for float64 is missing.

Author

srivathsanmurali commented Sep 26, 2016

I made a pr for the fix just in case

Owner

mkazhdan commented Oct 10, 2016

Thanks for catching that.

I have moved the fix into my code and will include it with the next version.

-- Misha

From: Srivathsan Murali [mailto:notifications@github.com]
Sent: Monday, September 26, 2016 10:35 AM
To: mkazhdan/PoissonRecon PoissonRecon@noreply.github.com
Subject: Re: [mkazhdan/PoissonRecon] float32 type size error (#16)

I made a pr for the fix just in case

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #16 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AKXc5f17PG2d7oA0EQgHSTaL6DLhFVzHks5qt9gJgaJpZM4KGmPP . https://github.com/notifications/beacon/AKXc5dEqZstHMCPVJYwaw7W-EIFGhXfyks5qt9gJgaJpZM4KGmPP.gif

srivathsanmurali closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment