Use OS' temporary directory for BufferedReadWriteFile

[twolfson]

We are using PoissonRecon in AWS Lambda which only permits creating files in its /tmp directory (OS' temporary directory):

http://docs.aws.amazon.com/lambda/latest/dg/limits.html

Currently BufferedReadWriteFile writes to the current working directory. As a workaround for now, we've hardcoded the BufferedReadWriteFile template to use the /tmp directory:

https://github.com/StandardCyborg/PoissonRecon/blob/93762c30d870752220973abb8252ca3b95e88d14/Src/Geometry.cpp#L52

I believe it's possible to find the OS' temporary directory via environment variables but am rather inexperienced in C++ and wanted to check the PR would be accepted first. If I wrote a PR to switch over to the OS' temporary directory, would you be interested in it in PoissonRecon?

[mkazhdan]

I have modified the code to support an additional “--tempDir” parameter which should allow you to specify the directory to which the temporary files will be written. Do not hesitate to contact me if this is not behaving appropriately.

…

-- Misha From: Todd Wolfson [mailto:notifications@github.com] Sent: Wednesday, August 16, 2017 7:36 PM To: mkazhdan/PoissonRecon <PoissonRecon@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: [mkazhdan/PoissonRecon] Use OS' temporary directory for BufferedReadWriteFile (#31) We are using PoissonRecon in AWS Lambda which only permits creating files in its /tmp directory (OS' temporary directory): http://docs.aws.amazon.com/lambda/latest/dg/limits.html Currently BufferedReadWriteFile writes to the current working directory. As a workaround for now, we've hardcoded the BufferedReadWriteFile template to use the /tmp directory: https://github.com/StandardCyborg/PoissonRecon/blob/93762c30d870752220973abb8252ca3b95e88d14/Src/Geometry.cpp#L52 I believe it's possible to find the OS' temporary directory via environment variables but am rather inexperienced in C++ and wanted to check the PR would be accepted first. If I wrote a PR to switch over to the OS' temporary directory, would you be interested in it in PoissonRecon? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#31> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AKXc5aTi7HXlSj6A5r1NWw2E2h7LjWmsks5sY3zFgaJpZM4O5m2q> . <https://github.com/notifications/beacon/AKXc5YE_2wJb5IK-LBlJBnUF7bqrrxluks5sY3zFgaJpZM4O5m2q.gif>

[twolfson]

Wow, this is awesome. Thanks a bunch @mkazhdan. I'll try it out tomorrow

I'm pre-emptively closing the issue now =)