-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master #6
base: master
Are you sure you want to change the base?
Master #6
Conversation
cignoni
commented
Nov 12, 2015
- _DepthAndOffset requires node as first parameter
- diagonal is a pointer so -> instead of .
* _DepthAndOffset require node * diagonal is a pointer
Hi, I was compiling the latest version on my mac and I got these two small errors, probably they are in unused branches of the basecode but clang is quite pedant... |
# Conflicts: # Src/SparseMatrix.inl
# Conflicts: # Src/SparseMatrix.inl
Updated the pull request. |
I confirm that this PR works perfectly, even with the 9.1 version. It successfully compiles on Visual 2013, g++ and clang. |
I'm not sure what you were seeing for line 339 in Src/MultiGridOctreeData.h, but I think Data can be a raw pointer (depending on the memory debugging setting), in which case taking size() makes no sense. I think _sz should be used instead. Update: that function isn't called anyway, so it's irrelevant. Could be commented out or removed. |
Add std namespace