Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OS' temporary directory for BufferedReadWriteFile #31

Closed
twolfson opened this issue Aug 16, 2017 · 2 comments
Closed

Use OS' temporary directory for BufferedReadWriteFile #31

twolfson opened this issue Aug 16, 2017 · 2 comments

Comments

@twolfson
Copy link

We are using PoissonRecon in AWS Lambda which only permits creating files in its /tmp directory (OS' temporary directory):

http://docs.aws.amazon.com/lambda/latest/dg/limits.html

Currently BufferedReadWriteFile writes to the current working directory. As a workaround for now, we've hardcoded the BufferedReadWriteFile template to use the /tmp directory:

https://github.com/StandardCyborg/PoissonRecon/blob/93762c30d870752220973abb8252ca3b95e88d14/Src/Geometry.cpp#L52

I believe it's possible to find the OS' temporary directory via environment variables but am rather inexperienced in C++ and wanted to check the PR would be accepted first. If I wrote a PR to switch over to the OS' temporary directory, would you be interested in it in PoissonRecon?

@mkazhdan
Copy link
Owner

mkazhdan commented Aug 22, 2017 via email

@twolfson
Copy link
Author

Wow, this is awesome. Thanks a bunch @mkazhdan. I'll try it out tomorrow

I'm pre-emptively closing the issue now =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants