Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load of binary stl files #17

Merged
merged 1 commit into from
Aug 7, 2014
Merged

Conversation

tytouf
Copy link
Collaborator

@tytouf tytouf commented Jul 13, 2014

These changes are meant to fix the crash described in issue #16 "Crash when loading a .stl file".
This commit also fixes the boundaries of the mesh.

@mkeeter
Copy link
Owner

mkeeter commented Jul 16, 2014

Hi Christophe,

I'm giving you commit access to kokopelli (as inspired by this discussion).

Feel free to merge in your pull request and other fixes / improvements you feel like making.

This PR appears to fix the crash, and I confirm that .stls still aren't being displayed. To be honest, I'm not entirely sure why I put in the option to load .stls -- I don't think that the CAM workflow works on them, so (if displaying them worked) all it would do is act as a viewer.

Regards,
Matt

@tytouf
Copy link
Collaborator Author

tytouf commented Jul 16, 2014

Hi Matt,

Thanks!

I agree that at the moment it would only serve as a viewer but it would be
great to make it generate an image of the depth map that can later be used
in the cam workflow.

Kind regards,

Hi Christophe,

I'm giving you commit access to kokopelli (as inspired by this discussion
http://felixge.de/2013/03/11/the-pull-request-hack.html).

Feel free to merge in your pull request and other fixes / improvements you
feel like making.

This PR appears to fix the crash, and I confirm that .stls still aren't
being displayed. To be honest, I'm not entirely sure why I put in the
option to load .stls -- I don't think that the CAM workflow works on them,
so (if displaying them worked) all it would do is act as a viewer.

Regards,
Matt


Reply to this email directly or view it on GitHub
#17 (comment).

tytouf added a commit that referenced this pull request Aug 7, 2014
Fix load of binary stl files
@tytouf tytouf merged commit 0be39cd into mkeeter:master Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants