Corrected entrypoint target for PHP7 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry to hear about the trouble you've been having. This image is already my next candidate for a CI build and automated tests, I plan to have that in place by next week to prevent this kind of instability. Thank you for the PR, I'll merge that in and test both image tags. |
|
Just to close the loop on this, I've merged the PR and executed a test with the PHP5 image. I also opened issue #3 to address the stability issue. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the update (at this time, 20 hours ago), all our builds fails testing, as
/System error: exec: "/as-user": stat /as-user: no such file or directory- I saw in the base image, that it'srun-as-userinstead, so I made changes to reflect that.Unfortunately, it's the third time this happens with the entrypoint, so I will build my own image, but I just thought I would make the PR at least :)
I haven't tested the PHP5 tag, so this only "fixes" the bug for PHP7.