Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected entrypoint target for PHP7 #2

Merged
merged 1 commit into from
Jul 8, 2016

Conversation

mewm
Copy link
Contributor

@mewm mewm commented Jul 8, 2016

After the update (at this time, 20 hours ago), all our builds fails testing, as /System error: exec: "/as-user": stat /as-user: no such file or directory - I saw in the base image, that it's run-as-user instead, so I made changes to reflect that.

Unfortunately, it's the third time this happens with the entrypoint, so I will build my own image, but I just thought I would make the PR at least :)

I haven't tested the PHP5 tag, so this only "fixes" the bug for PHP7.

@mkenney
Copy link
Owner

mkenney commented Jul 8, 2016

Sorry to hear about the trouble you've been having. This image is already my next candidate for a CI build and automated tests, I plan to have that in place by next week to prevent this kind of instability. Thank you for the PR, I'll merge that in and test both image tags.

@mkenney mkenney merged commit 269962b into mkenney:master Jul 8, 2016
@mkenney
Copy link
Owner

mkenney commented Jul 8, 2016

Just to close the loop on this, I've merged the PR and executed a test with the PHP5 image. I also opened issue #3 to address the stability issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants