Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Slack) improvement: suppress possible irrelevant error on upgrade #66

Merged
merged 1 commit into from
Sep 6, 2020
Merged

(Slack) improvement: suppress possible irrelevant error on upgrade #66

merged 1 commit into from
Sep 6, 2020

Conversation

wolffberg
Copy link
Contributor

@wolffberg wolffberg commented Sep 5, 2020

Description

Non-terminating error is thrown when running choco upgrade slack -y

Fixes #65

Motivation and Context

Installer should run without errors even if slack.exe is not running.

How Has this Been Tested?

Command has been run in PowerShell V2.0 without errors both with and without slack.exe running.

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@wolffberg wolffberg changed the title improvement: suppress possible irrelevant error on upgrade (Slack) improvement: suppress possible irrelevant error on upgrade Sep 5, 2020
@hixio-mh
Copy link

hixio-mh commented Sep 6, 2020

Merged pull request

Copy link
Owner

@mkevenaar mkevenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkevenaar mkevenaar merged commit 3eeba56 into mkevenaar:master Sep 6, 2020
@mkevenaar
Copy link
Owner

mkevenaar commented Sep 6, 2020

@wolffberg Your changes have been merged, this will ship with the next version of Slack and will come into play the version after that.

The chocolateyBeforeModify script gets called from the currently installed package version, not from the version pushed with this package.

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Slack) Non-terminating error on upgrade if slack.exe is not running
4 participants