Package updates #22
Merged
Package updates #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that as of glob 5, exclude patterns are supported out of the box. Maybe the dependency on minimatch isn't strictly necessary? It's hard to tell quickly. Since glob 6 removes support for comment and negation patterns, this may or may not be a breaking change from fileset's pov.
Over the last year or so, we've settled on `"license":"<SPDX-term>"` for specifying licenses in a more machine-readable and human-convenient format.
|
It would be awesome if this pull request could be accepted by Mickael. The Glob version is hopelessly outdated. |
|
I dont know how I missed that PR. Thanks a lot @isaacs and sorry for the delay. Merging. Will follow up with a publish to the registry a bit later today. |
Yes, I recently saw that you added the Thanks again for the PR, really appreciated. |
This was referenced Jun 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 updates to package.json. One for license and the other to update glob and minimatch.
Note that as of glob 5, exclude patterns are supported out of the box. Maybe the dependency on minimatch isn't strictly necessary? It's hard to tell quickly.
Since glob 6 removes support for comment and negation patterns, this may or may not be a breaking change from fileset's pov.