#45 Fix Host header on forwarded requests #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardBradley
commented
Mar 16, 2018
| headers.putAll(response.getHeaders()); | ||
| response.setHeaders(headers); | ||
|
|
||
| headers.remove("Transfer-Encoding"); |
There was a problem hiding this comment.
Remote servers which use Chunked transfer encoding would fail to proxy correctly because line 85 causes Spring to buffer the remote body into a single entity, but we were previously passing over the remote Transfer-Encoding: Chunked header, confusing clients.
This fixes that issue. I have tested against a remote server with Chunked encoding, it works after this change but did not work before this change.
I have not added a unit test for this fix.
RichardBradley
commented
Mar 16, 2018
| @@ -145,6 +145,7 @@ abstract class ProxyingRequestSpec extends BasicSpec { | |||
|
|
|||
| then: | |||
| assertThat(response) | |||
| .hasStatus(MOVED_PERMANENTLY) | |||
| .hasStatus(OK) | |||
| .bodyContains("<link rel=\"canonical\" href=\"https://github.com/\"") | |||
There was a problem hiding this comment.
See comment in the body of this PR -- the test was actually failing before, i.e. the old assertion was wrong.
After fixing the Host header issue, the request now works, so I have fixed the assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #45
The test "
def "Should proxy HTTPS request"()" demonstrates that this fix works -- previously TLS requests that were being forwarded to https://github.com had aHostheader oflocalhost, and were being rejected by GitHub's server. Now the request is succeeding.