Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added file generation for SceneBuilder integration #28

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

ennerf
Copy link
Contributor

@ennerf ennerf commented Dec 3, 2022

see #27

mvn package -pl styles generates an additional AtlantaFX-1.1.0-scenebuilder.zip file that maps the AtlantaFX themes to SceneBuilder buttons. I wasn't sure how to change the docs, so I just packed instructions into the Readme.

What do you think about adding a button in the sampler app that installs Themes into SceneBuilder w/o requiring manual steps? It'd be nice to make the integration as simple as possible.

@mkpaz mkpaz merged commit e485b28 into mkpaz:master Dec 11, 2022
@mkpaz
Copy link
Owner

mkpaz commented Dec 11, 2022

Thanks! And sorry for the late response.

I think it's possible to add integration section above or below the color palette at the Theme page. It may look as follows:

  • AtlantaFX-1.1.0-scenebuilder.zip is injected into jlink image at build stage
  • User presses install button and selects the path to the Scene Builder binary (maybe with a little help if Scene Builder binary is present in the $PATH)
  • Install script unpack and transfers CSS files to the Scene Builder installation dir and changes config file appropriately

We should also provide uninstall option to make the change reversible.

I'm not Scene Builder user so I don't how to handle two situations. Whether Scene Builder supports auto-updates and what happens in that case. How it will work when Scene Builder is not used as standalone app but integrated into IDE.

@ennerf ennerf deleted the scenebuilder branch December 13, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants