Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6: ability to start/stop timer #7

Merged
merged 1 commit into from
Nov 16, 2016

Conversation

nick4fake
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Nov 16, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling b65aab6 on Werkint:timer-fix into a3461ce on mkraemer:master.

@mkraemer
Copy link
Owner

Cool stuff, thanks!

Tests fails on PHP5.4 because of the used class constant in L48 of PCNTLTest.php
Can you replace it with 'React\EventLoop\Timer\TimerInterface'?

I'll merge and release a new version :)

@nick4fake
Copy link
Author

oh, sorry, my fault. Did not notice you are supporting PHP 5.4.

Will do that soon

@mkraemer
Copy link
Owner

Yeah, no worries :) As soon as there's a good reason for dropping support for 5.4 I'm good with that, but in this case it doesn't seem necessary.. thx

@coveralls
Copy link

coveralls commented Nov 16, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling ccf4835 on Werkint:timer-fix into a3461ce on mkraemer:master.

@mkraemer mkraemer merged commit b410b6e into mkraemer:master Nov 16, 2016
@mkraemer
Copy link
Owner

I've tagged release v2.2.0

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants