Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

Unauthorized read, post and delete messages in project discussion #124

Closed
xiaoyinl opened this issue Mar 23, 2018 · 0 comments
Closed

Unauthorized read, post and delete messages in project discussion #124

xiaoyinl opened this issue Mar 23, 2018 · 0 comments
Assignees
Labels

Comments

@xiaoyinl
Copy link

For example, if user1 creates a project and invites some users into this project. User2 is not in this project. If user2 visits http://127.0.0.1/librarian/discussion.php?project=1 directly, he gets "Error! You are not authorized to see this project." But if user2 visits http://127.0.0.1/librarian/ajaxdiscussion.php?project=1&read=1, he is able to read the messages for this project. Similarly user2 can use project=1&delete=1 to delete all messages, and project=1&newmessage=... to post new messages.

The bug is in ajaxdiscussion.php. Unlike discussion.php, ajaxdiscussion.php doesn't check if the current user is in the specified project.

@xiaoyinl xiaoyinl changed the title Unauthorized read, post and delete messages in arbitrary projects Unauthorized read, post and delete messages in project discussion Mar 23, 2018
@mkucej mkucej self-assigned this Mar 23, 2018
@mkucej mkucej added the bug label Mar 23, 2018
mkucej added a commit that referenced this issue Mar 23, 2018
@mkucej mkucej closed this as completed Apr 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants