Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS related configuration moved to storage package #95

Merged
merged 5 commits into from
Aug 27, 2023
Merged

Conversation

mkuthan
Copy link
Owner

@mkuthan mkuthan commented Aug 27, 2023

Closes #94

  • DLQ storage related configuration in the storage package
  • Fix "write on GCS as two JSON files if there are two windows" DLQ test scenario

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #95 (c3cf55a) into main (58684a0) will increase coverage by 0.74%.
The diff coverage is 67.85%.

@@             Coverage Diff              @@
##               main      #95      +/-   ##
============================================
+ Coverage     53.04%   53.78%   +0.74%     
- Complexity       97      106       +9     
============================================
  Files            77       78       +1     
  Lines           986      991       +5     
  Branches        123      120       -3     
============================================
+ Hits            523      533      +10     
+ Misses          393      387       -6     
- Partials         70       71       +1     
Files Changed Coverage Δ
...ng/infrastructure/bigquery/ScioContextSyntax.scala 85.71% <ø> (ø)
.../infrastructure/diagnostic/SCollectionSyntax.scala 100.00% <ø> (ø)
...ocessing/infrastructure/dlq/DlqConfiguration.scala 76.19% <ø> (-0.74%) ⬇️
...sing/infrastructure/pubsub/SCollectionSyntax.scala 93.75% <ø> (ø)
...cessing/infrastructure/storage/StorageBucket.scala 0.00% <0.00%> (ø)
...reamprocessing/shared/scio/SCollectionSyntax.scala 92.85% <ø> (ø)
...reamprocessing/test/scio/TimestampedMatchers.scala 0.00% <0.00%> (ø)
...cessing/infrastructure/storage/StorageParams.scala 40.90% <37.50%> (ø)
.../infrastructure/storage/StorageConfiguration.scala 83.33% <83.33%> (ø)
...cessing/infrastructure/dlq/SCollectionSyntax.scala 94.73% <100.00%> (+1.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mkuthan mkuthan merged commit 29f8aa8 into main Aug 27, 2023
5 checks passed
@mkuthan mkuthan deleted the storage_io branch August 27, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IO for GCS
1 participant