Add ability to enumerate over a specific mount in the search path #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaywardHeart
added a commit
to WaywardHeart/mkxp-z
that referenced
this pull request
Mar 31, 2024
This commit requires mkxp-z/physfs#1, which allows us to enumerate files in specific mount points. This allows us to guarantee that the highest priority file is chosen, even if the directory path has different cases in different archives.
WaywardHeart
added a commit
to WaywardHeart/mkxp-z
that referenced
this pull request
Apr 11, 2024
This commit requires mkxp-z/physfs#1, which allows us to enumerate files in specific mount points. This allows us to guarantee that the highest priority file is chosen, even if the directory path has different cases in different archives.
…le mount in the search path.
…at a specific mount point
…'s entry count. It's currently set to try to have 8-16 items per bucket. ISO9660 and hog archives still use the default 64 buckets due to not being able to easily get their file counts.
Resolving the files for this can significantly increase enumeration time if a lot of files are being accessed for the first time
WaywardHeart
force-pushed
the
enumerateSinglePath
branch
from
6b8200d
to
996cb6c
Compare
WaywardHeart
added a commit
to WaywardHeart/mkxp-z
that referenced
this pull request
Apr 18, 2024
This commit requires mkxp-z/physfs#1, which allows us to enumerate files in specific mount points. This allows us to guarantee that the highest priority file is chosen, even if the directory path has different cases in different archives.
…chives Speeds up mounting zip archives with large file counts.
WaywardHeart
force-pushed
the
enumerateSinglePath
branch
from
996cb6c
to
bee9e0b
Compare
JaidenAlemni
pushed a commit
to JaidenAlemni/mkxp-z-astravia
that referenced
this pull request
Jun 21, 2024
This commit requires mkxp-z/physfs#1, which allows us to enumerate files in specific mount points. This allows us to guarantee that the highest priority file is chosen, even if the directory path has different cases in different archives.
JaidenAlemni
pushed a commit
to JaidenAlemni/mkxp-z-astravia
that referenced
this pull request
Jun 21, 2024
This commit requires mkxp-z/physfs#1, which allows us to enumerate files in specific mount points. This allows us to guarantee that the highest priority file is chosen, even if the directory path has different cases in different archives.
JaidenAlemni
pushed a commit
to JaidenAlemni/mkxp-z-astravia
that referenced
this pull request
Jun 25, 2024
This commit requires mkxp-z/physfs#1, which allows us to enumerate files in specific mount points. This allows us to guarantee that the highest priority file is chosen, even if the directory path has different cases in different archives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out to be simple to add, fortunately. This will help with building the path cache in mkxp-z.