Standard optimization test functions #7

jairodelgado · 2019-10-02T14:33:17Z

Fix #6

alejandrom247 · 2019-10-02T14:45:59Z

This pull request requires a review a intend to deal with issue #6

jairodelgado

@alejandrom247 what do you think if we wrap all benchmark functions in a new namespace within solution namespace, e.g.: dnn_opt::core::solutions::benchmark. That way I would suggest to create a new directory inside src/core/solutions and include not only the new benchmark functions you are impementing now but the old ones...

src/core/solutions/brown_function.cpp

src/core/solutions/chung_reynolds_function.cpp

src/core/solutions/chung_reynolds_function.h

src/core/solutions/cosine_mixture.cpp

standard code modifications.

alejandrom247

This the Csendes plus the standard code revision

jairodelgado

Coding standards compliance still needs to be improved.

src/core/solutions/brown_function.cpp

src/core/solutions/chung_reynolds_function.h

src/core/solutions/cosine_mixture.cpp

src/core/solutions/csendes.cpp

src/core/solutions/brown_function.h

src/core/solutions/chung_reynolds.cpp

src/core/solutions/chung_reynolds.h

src/core/solutions/cosine_mixture.cpp

src/core/solutions/csendes.cpp

jairodelgado · 2019-10-24T23:10:11Z

I have a dude. The int to reference the position of the array of params can be int or also should be convert in float??

It has to be int. Indexes are integer.

Use float literals only inside aritmetic operations that are meant to be float.

src/core/solutions/brown_function.cpp

src/core/solutions/chung_reynolds_function.cpp

src/core/solutions/chung_reynolds_function.h

…mplementations.

src/core/solutions/dixonp.cpp

src/core/solutions/eggh.cpp

src/core/solutions/expo.h

src/core/solutions/eggh.h

src/core/solutions/giunta.h

…lementations. Add the implementations ref to dnn_opt

…ader

src/core/solutions/bench/brown_function.h

src/core/solutions/bench/chung_reynolds.h

src/core/solutions/bench/cosine_mixture.h

alejandrom247 and others added 3 commits October 1, 2019 20:45

Addes de Brown Funcction header and cpp to implement this test function

bbdc53c

Addes de Chung Reynolds header and cpp to implement this test function

3a3d266

Addes de Cosine Mixture header and cpp to implement this test function

0088e78

jairodelgado added the enhancement label Oct 2, 2019

jairodelgado assigned alejandrom247 Oct 2, 2019

jairodelgado commented Oct 2, 2019

View reviewed changes

alejandrom247 added 2 commits October 2, 2019 10:34

Addes de Csendes header and cpp to implement this test function

cb0aea6

Addes de Csendes header and cpp to implement this test function. And the

2e9c2c3

standard code modifications.

alejandrom247 reviewed Oct 2, 2019

View reviewed changes

jairodelgado commented Oct 2, 2019

View reviewed changes

fixup code standard improvements

3292754

jairodelgado commented Oct 18, 2019

View reviewed changes

Add the Deb 3 function implementation and fixup the code issues

fad06fd

jairodelgado commented Oct 24, 2019

View reviewed changes

Add the Dixon & Price, Egg Holder, Exponential and Giunta functions i…

7856ab5

…mplementations.

jairodelgado commented Nov 7, 2019

View reviewed changes

src/core/solutions/dixonp.cpp Outdated Show resolved Hide resolved

src/core/solutions/eggh.cpp Outdated Show resolved Hide resolved

src/core/solutions/expo.h Outdated Show resolved Hide resolved

jairodelgado commented Nov 7, 2019

View reviewed changes

src/core/solutions/eggh.h Outdated Show resolved Hide resolved

src/core/solutions/giunta.h Outdated Show resolved Hide resolved

alejandrom247 added 3 commits November 10, 2019 20:30

Add the correction to the code.

b0f0c46

Definition of namespace bench wchih defones de benchmark function imp…

b5cbe90

…lementations. Add the implementations ref to dnn_opt

I forgot in the last commit submit the modification to the dnn_opt he…

f46bbbe

…ader

jairodelgado commented Nov 19, 2019

View reviewed changes

src/core/solutions/bench/brown_function.h Outdated Show resolved Hide resolved

src/core/solutions/bench/chung_reynolds.h Show resolved Hide resolved

src/core/solutions/bench/cosine_mixture.h Show resolved Hide resolved

jairodelgado changed the title ~~Sequential test functions~~ Standard optimization test functions Jan 26, 2020

fixup author metadata docs and ward names

e6a45fd

jairodelgado merged commit 801f8be into master Jan 30, 2020

jairodelgado deleted the brown_function branch January 30, 2020 04:06

jairodelgado mentioned this pull request Jan 30, 2020

OMP - standard optimization test functions #10

Open

10 tasks

jairodelgado mentioned this pull request Feb 8, 2020

CUDA - standard optimization test functions #14

Open

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Standard optimization test functions #7

Standard optimization test functions #7

jairodelgado commented Oct 2, 2019 •

edited

Loading

alejandrom247 commented Oct 2, 2019

jairodelgado left a comment

alejandrom247 left a comment

jairodelgado left a comment

jairodelgado commented Oct 24, 2019

Standard optimization test functions #7

Standard optimization test functions #7

Conversation

jairodelgado commented Oct 2, 2019 • edited Loading

alejandrom247 commented Oct 2, 2019

jairodelgado left a comment

Choose a reason for hiding this comment

alejandrom247 left a comment

Choose a reason for hiding this comment

jairodelgado left a comment

Choose a reason for hiding this comment

jairodelgado commented Oct 24, 2019

jairodelgado commented Oct 2, 2019 •

edited

Loading