Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update neural-network.md #1010

Closed
wants to merge 1 commit into from

Conversation

langfan94
Copy link

change input r,g,b number => string

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

A good PR 🌟

β†’ Step 1: Which branch are you submitting to? 🌲

Development (for new features or updates)

β†’ Step 2: Describe your Pull Request πŸ“

Update input r,g,b number => string

A great PR 🌟🌟

β†’ Step 3: Share a Relevant Example πŸ¦„

Here's some example code or a demonstration of my feature as a part of this pull request, a separate pull request, in the https://editor.p5js.org, or codepen/jsfiddle/etc...

The best PR 🌟🌟🌟

β†’ Step 4: Screenshots or Relevant Documentation πŸ–Ό

Here's some helpful screenshots and/or documentation of the new feature

change input r,g,b number => string
@joeyklee
Copy link
Contributor

@langfan94 - Hi! Thanks for taking the time to make these documentation suggestions. Can you explain why there is a need to change the numbers to strings?

From the documentation changes I'm not sure why this is necessary. Any clarifications and additional details would be great! Thanks!

@langfan94 langfan94 closed this Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants