Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1379 introduces new eslint rules, which I suppressed in that PR. Here I am actually remedying a bunch of them in the code.
npx eslint src --fix
to automatically fix all violations for rules:arrow-body-style
import/no-useless-path-segments
no-else-return
prefer-regex-literals
prefer-object-spread
lines-between-class-members
= null
default parameters which violateddefault-param-last
prefer-regex-literals
Fixed in other PRs:
no-constructor-return
are fixed by Refactor: breakup ImageClassifier #1362prefer-regex-literals
is deleted in Better handling of model URL formation #1376Prior to fixing, these are the counts of violations in
/src
(including test files):All violations of
no-unused-vars
are in test files (this rule is not new).