Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch pylint for Ruff #12

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Switch pylint for Ruff #12

merged 3 commits into from
Mar 10, 2023

Conversation

RobbeSneyders
Copy link
Member

Based on Niels' suggestion.

Ruff is a lot faster than Pylint and an also prevents the need for isort. While it doesn't completely cover all pylint checks, a lot of the non-covered issues will be covered by bandit or mypy (still to add) instead.

Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@RobbeSneyders RobbeSneyders merged commit 1960a50 into main Mar 10, 2023
PhilippeMoussalli added a commit that referenced this pull request Mar 14, 2023
Based on [Niels'
suggestion](#11 (comment)).

Ruff is a lot faster than Pylint and an also prevents the need for
isort. While it [doesn't completely cover all pylint
checks](astral-sh/ruff#970), a lot of the
non-covered issues will be covered by bandit or mypy (still to add)
instead.
@RobbeSneyders RobbeSneyders deleted the feature/ruff branch May 15, 2023 16:30
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
Based on [Niels'
suggestion](#11 (comment)).

Ruff is a lot faster than Pylint and an also prevents the need for
isort. While it [doesn't completely cover all pylint
checks](astral-sh/ruff#970), a lot of the
non-covered issues will be covered by bandit or mypy (still to add)
instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants