Update metadata #72
Merged
Update metadata #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeMoussalli
approved these changes
May 4, 2023
NielsRogge
force-pushed
the
fix_metadata_bis
branch
from
b86014d
to
b049c18
Compare
|
Don't merge yet as running |
RobbeSneyders
approved these changes
May 4, 2023
There was a problem hiding this comment.
Thanks @NielsRogge!
Looks good to me, one minor comment.
If you want to test component.run(), we should mock / monkeypatch some stuff. This will probably come in handy for other tests as well. I added some steps towards this in #74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the passing of metadata, by only making loading components accept an args.metadata argument that only includes the
run_idof the pipeline as well as thebase_path. Transform components don't need a metadata argument anymore as they just update thecomponent_idwhich we can get from the component spec (FondantComponentSpec).Fixes #69