Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hidden size assertion in LLaMA model #2848

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Remove hidden size assertion in LLaMA model #2848

merged 1 commit into from
Aug 24, 2024

Conversation

YiyanZhai
Copy link
Contributor

This PR removed assert self.head_dim * self.num_attention_heads == self.hidden_size from llama_model.py, since this assertion is not always true -- LLaMA variants may have different relationships num_attention_heads * head_dim.

@YiyanZhai YiyanZhai mentioned this pull request Aug 24, 2024
Closed
MasterJH5574
MasterJH5574 approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@MasterJH5574 MasterJH5574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @YiyanZhai!

@MasterJH5574 MasterJH5574 merged commit 9336aab into mlc-ai:main Aug 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterJH5574 MasterJH5574 MasterJH5574 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YiyanZhai @MasterJH5574