Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Op][Trans3] Concat, Split #80

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

MasterJH5574
Copy link
Member

This PR is the third part of transformation operator migration, as listed in #62.

It only contains two operators: Concat and Split. These two come with more complicated structure info inference, and have very many test cases.

cc @tqchen

Copy link
Contributor

@tqchen tqchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments, overall LGTM

src/relax/op/tensor/manipulate.cc Outdated Show resolved Hide resolved
src/relax/op/tensor/manipulate.cc Show resolved Hide resolved
src/relax/op/tensor/manipulate.cc Show resolved Hide resolved
src/relax/op/tensor/manipulate.cc Outdated Show resolved Hide resolved
src/relax/op/tensor/manipulate.cc Outdated Show resolved Hide resolved
@tqchen tqchen merged commit 6e2301c into mlc-ai:structinfo Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants