[Op][Index] Take, StridedSlice #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
MasterJH5574
force-pushed
the
mlc-dev/2023-01-04-index
branch
from
5d62abe
to
7f14313
Compare
MasterJH5574
force-pushed
the
mlc-dev/2023-01-04-index
branch
from
7f14313
to
6753fd6
Compare
MasterJH5574
force-pushed
the
mlc-dev/2023-01-04-index
branch
from
6753fd6
to
8937cfe
Compare
tqchen
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As listed in #62, this PR introduces the indexing operator
takeandstrided_slice.Note that DataAPI only has
take. However, as slicing is a common operation for arrays/tensors in NumPy and PyTorch, we also bringstrided_slicefor those cases. Though astrided_sliceoperation is a combination of multipletakes along different axes, havingstrided_sliceeases the effort of fusing multiple contiguoustakes and is thus worth being introduced.