Fix CPU database compare #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inimaz
approved these changes
May 15, 2024
There was a problem hiding this comment.
Nice catch @benoit-cty ! Looks good to me.
Checking the test you changed, it is weird that it worked with Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (line 185) but did not work with Intel(R) Xeon(R) Gold 6330N CPU @ 2.20Ghz case. They look very similar.
Yes, I don't understand why it was failling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some case the fuzzy matching did not work on Intel CPU, this PR is fixing that, at least for "Intel(R) Xeon(R) Gold 6330N CPU @ 2.20Ghz" that was not matching "Intel Xeon Gold 6330N".
Will close #547