Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing different device issue on multi-layer UNet and UNETR #399

Merged
merged 11 commits into from
Apr 18, 2022

Conversation

sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Apr 12, 2022

Fixes #N.A.

Proposed Changes

  • using torch.nn.ModuleList instead of []
  • added numbers to the tests to make it easier to track which ones fail
  • specify scikit-image version

Checklist

  • I have read the CONTRIBUTING guide
  • My PR is based from the current GaNDLF master
  • Non-breaking change (would not break existing functionality): please provide as many details as possible for any breaking change
  • Function/class source code documentation added/updated
  • Code has been blacked for style consistency
  • If applicable, version information has been updated in GANDLF/version.py
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
  • Usage documentation has been updated, if appropriate
  • History has been updated, if appropriate
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

@dagshub
Copy link

dagshub bot commented Apr 12, 2022

@sarthakpati sarthakpati changed the title Fixing different device issue on multi-layer unet Fixing different device issue on multi-layer UNet Apr 12, 2022
@sarthakpati sarthakpati changed the title Fixing different device issue on multi-layer UNet Fixing different device issue on multi-layer UNet and UNETR Apr 12, 2022
@sarthakpati sarthakpati marked this pull request as draft April 12, 2022 18:56
@sarthakpati sarthakpati marked this pull request as ready for review April 12, 2022 18:59
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #399 (dee7452) into master (3e35ff0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
+ Coverage   92.02%   92.04%   +0.02%     
==========================================
  Files         101      101              
  Lines        6003     6011       +8     
==========================================
+ Hits         5524     5533       +9     
+ Misses        479      478       -1     
Flag Coverage Δ
unittests 92.04% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
GANDLF/models/light_unet_multilayer.py 98.00% <100.00%> (+0.04%) ⬆️
GANDLF/models/unet_multilayer.py 92.30% <100.00%> (+0.47%) ⬆️
GANDLF/models/unetr.py 97.08% <100.00%> (+0.01%) ⬆️
testing/test_full.py 98.23% <100.00%> (+<0.01%) ⬆️
...NDLF/data/preprocessing/template_matching/utils.py 97.67% <0.00%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e35ff0...dee7452. Read the comment docs.

@Geeks-Sid Geeks-Sid merged commit cde628d into mlcommons:master Apr 18, 2022
@sarthakpati sarthakpati deleted the multilayer_fixes branch April 18, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants