Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new optimizers #646

Merged
merged 11 commits into from
May 20, 2023
Merged

Added new optimizers #646

merged 11 commits into from
May 20, 2023

Conversation

AdiSir05
Copy link
Collaborator

@AdiSir05 AdiSir05 commented May 15, 2023

Fixes #586

Proposed Changes

  • Added the RAdam and LBFGS Optimizers

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • History has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

Added the RAdam and LBFGS Optimizers
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati mentioned this pull request May 15, 2023
11 tasks
@sarthakpati sarthakpati changed the title Update wrap_torch.py Added new optimizers May 15, 2023
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs the key to be added in GANDLF.optimizers.__init__.py.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #646 (afd45f2) into master (c822d07) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head afd45f2 differs from pull request most recent head bb88242. Consider uploading reports for the commit bb88242 to get more accurate results

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
- Coverage   94.33%   94.32%   -0.02%     
==========================================
  Files         114      114              
  Lines        7677     7679       +2     
==========================================
+ Hits         7242     7243       +1     
- Misses        435      436       +1     
Flag Coverage Δ
unittests 94.32% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
GANDLF/optimizers/__init__.py 87.50% <ø> (ø)
GANDLF/optimizers/wrap_torch.py 96.29% <100.00%> (+0.29%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Geeks-Sid
Geeks-Sid previously approved these changes May 15, 2023
@Geeks-Sid Geeks-Sid dismissed their stale review May 15, 2023 19:47

I think the tests are not covered right now.

@Geeks-Sid
Copy link
Collaborator

@AdiSir05 , Please sign the CLA so that we can add this PR. The CLA bot mentioned above should provide you with the required links.

@AdiSir05
Copy link
Collaborator Author

@Geeks-Sid I have signed the CLA

@sarthakpati
Copy link
Collaborator

It seems LBFGS expects a separate closure arg in its step [ref]. Does it make sense to keep it or shall we discard LBFGS for simplicity?

@Geeks-Sid
Copy link
Collaborator

I agree with @sarthakpati . Maybe skip that optimizer for now. @AdiSir05 Please update the PR so that you can have your first contribution! Welcome to GaNDLF family.

sarthakpati
sarthakpati previously approved these changes May 19, 2023
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after tests.

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakpati sarthakpati merged commit b6dc393 into mlcommons:master May 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add another optimizer (or 2) as option
3 participants