-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new optimizers #646
Added new optimizers #646
Conversation
Added the RAdam and LBFGS Optimizers
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs the key to be added in GANDLF.optimizers.__init__.py
.
Codecov Report
@@ Coverage Diff @@
## master #646 +/- ##
==========================================
- Coverage 94.33% 94.32% -0.02%
==========================================
Files 114 114
Lines 7677 7679 +2
==========================================
+ Hits 7242 7243 +1
- Misses 435 436 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I think the tests are not covered right now.
@AdiSir05 , Please sign the CLA so that we can add this PR. The CLA bot mentioned above should provide you with the required links. |
@Geeks-Sid I have signed the CLA |
It seems LBFGS expects a separate |
I agree with @sarthakpati . Maybe skip that optimizer for now. @AdiSir05 Please update the PR so that you can have your first contribution! Welcome to GaNDLF family. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #586
Proposed Changes
Checklist
CONTRIBUTING
guide.pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].