-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding mechanism to curate each extracted patch #653
Conversation
Added to code to curate the patches, discard the patches if tissue in patch is less than 30%, and if there is any other artifact as glass reflection, pen markings.
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Minor syntactic changes requested.
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
Thanks for the contribution, @shubhaminnani! Let me know once you have signed and submitted the CLA, and I can re-check this. |
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
==========================================
+ Coverage 94.60% 94.62% +0.02%
==========================================
Files 116 116
Lines 8038 8056 +18
==========================================
+ Hits 7604 7623 +19
+ Misses 434 433 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a major round of changes that stems from the fact that there is no unit test coverage for this code addition. Going back from there, I am seeing a bunch of places where the code is brittle and can cause breaks/crashes.
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
Hey @shubhaminnani, I have converted this PR to draft until it is ready for review once again (at least once the tests are all passing). All the best! 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested.
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added to code to curate the patches, discard the patches if tissue in patch is less than 30%, and if there is any other artifact as glass reflection, pen markings.
Fixes #652
Proposed Changes
Checklist
CONTRIBUTING
guide.pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].