Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image similarity metrics #669

Merged
merged 60 commits into from
Jun 15, 2023

Conversation

sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Jun 7, 2023

Fixes #668

Proposed Changes

  • added metrics for image similarity metrics
  • because the torchmetrics version needed to be updated, some API changes needed to happen

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • History has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati marked this pull request as draft June 7, 2023 23:14
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #669 (0e155e5) into master (23b5005) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
+ Coverage   94.42%   94.52%   +0.10%     
==========================================
  Files         115      116       +1     
  Lines        7879     8006     +127     
==========================================
+ Hits         7440     7568     +128     
+ Misses        439      438       -1     
Flag Coverage Δ
unittests 94.52% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
GANDLF/metrics/classification.py 100.00% <ø> (ø)
GANDLF/metrics/regression.py 92.68% <ø> (ø)
GANDLF/utils/__init__.py 100.00% <ø> (ø)
GANDLF/cli/generate_metrics.py 100.00% <100.00%> (ø)
GANDLF/metrics/__init__.py 100.00% <100.00%> (ø)
GANDLF/metrics/generic.py 95.00% <100.00%> (ø)
GANDLF/metrics/synthesis.py 100.00% <100.00%> (ø)
GANDLF/utils/tensor.py 87.04% <100.00%> (+0.78%) ⬆️
testing/test_full.py 99.15% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Geeks-Sid Geeks-Sid merged commit 048722e into mlcommons:master Jun 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2023
@sarthakpati sarthakpati deleted the add_image_similarlity_metrics branch June 15, 2023 03:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics to compare 2 images
2 participants