-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added mask to SSIM function call #685
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
@FelixSteinbauer Thanks for your first contribution to GaNDLF. I request you sign the CLA provided by the @CLA Bot before we approve your PR. :) |
I did fill out the google form a few hours ago. I got a confirmation mail regarding my google form submission. Should I have gotten another/additional email? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No need. Once it gets recorded in the system, it will auto-propagate. 😄 |
Codecov Report
@@ Coverage Diff @@
## master #685 +/- ##
=======================================
Coverage 94.62% 94.62%
=======================================
Files 116 116
Lines 8054 8054
=======================================
Hits 7621 7621
Misses 433 433
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
As soon as I find a printer and scanner, the cla-check will also pass 👍 (probably tomorrow) |
I think the mask should also be provided to the SSIM function call. As the mask variable is always present/valid (either a proper mask if provided by the user or all-ones, see variable initialisation), it should be fine to simply add the mask as parameter to the call.
In my opinion, structural_similarity_index() should work fine with this additional parameter and nothing should break. However, I did not test the suggested code change.
This really is just a very minor change so please don't be mad at me for not following the standard PR procedure UwU
Proposed Changes
Checklist
CONTRIBUTING
guide.