Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the metrics output #687

Merged

Conversation

sarthakpati
Copy link
Collaborator

Fixes #686

Proposed Changes

  • metrics that were getting encoded as lists will now show as string separated using _ (we can change this as requirements change in the future)
  • added a single function to collect, format, and print the metrics

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • History has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@sarthakpati sarthakpati marked this pull request as draft July 6, 2023 18:14
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati changed the title Metrics will show up as normal strings instead of lists Updated the metrics output Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #687 (1bcc4af) into master (29e4560) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 1bcc4af differs from pull request most recent head c233c3b. Consider uploading reports for the commit c233c3b to get more accurate results

@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
- Coverage   94.62%   94.61%   -0.01%     
==========================================
  Files         116      116              
  Lines        8054     8062       +8     
==========================================
+ Hits         7621     7628       +7     
- Misses        433      434       +1     
Flag Coverage Δ
unittests 94.61% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
GANDLF/utils/__init__.py 100.00% <ø> (ø)
GANDLF/compute/forward_pass.py 93.58% <100.00%> (-0.17%) ⬇️
GANDLF/compute/training_loop.py 83.11% <100.00%> (-0.43%) ⬇️
GANDLF/utils/generic.py 90.65% <100.00%> (+2.14%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sarthakpati sarthakpati marked this pull request as ready for review July 6, 2023 19:46
@sarthakpati sarthakpati merged commit ca62e88 into mlcommons:master Jul 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2023
@sarthakpati sarthakpati deleted the change_metrics_list_to_string branch July 8, 2023 03:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per-label and per-class metrics should be formatted properly for CSV output
2 participants