Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed plotting function for final stats #691

Merged
merged 11 commits into from
Jul 14, 2023

Conversation

Geeks-Sid
Copy link
Collaborator

Fixes #334

Proposed Changes

Plotting is now worked on automatically for all columns except for per_class, per_label and global which are separated by _

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati changed the title removed annoying comments Fixed plotting function for final stats Jul 10, 2023
@sarthakpati sarthakpati marked this pull request as draft July 10, 2023 18:16
@sarthakpati sarthakpati self-requested a review July 11, 2023 15:38
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested.

GANDLF/utils/plot_utils.py Outdated Show resolved Hide resolved
GANDLF/utils/plot_utils.py Outdated Show resolved Hide resolved
GANDLF/utils/plot_utils.py Outdated Show resolved Hide resolved
GANDLF/utils/plot_utils.py Outdated Show resolved Hide resolved
Geeks-Sid and others added 2 commits July 11, 2023 12:04
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #691 (0918202) into master (ca62e88) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #691   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files         116      116           
  Lines        8062     8062           
=======================================
  Hits         7629     7629           
  Misses        433      433           
Flag Coverage Δ
unittests 94.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Geeks-Sid Geeks-Sid marked this pull request as ready for review July 13, 2023 14:42
@Geeks-Sid
Copy link
Collaborator Author

@sarthakpati Ready to review

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakpati sarthakpati merged commit 8a8e437 into mlcommons:master Jul 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trouble collecting stats
2 participants