-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding second classification tutorial #698
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Thanks for the PR, @vavali08! 2 major points before I proceed with a review:
|
…ation_tutorial_notebook/classification_tutorial.ipynb
Hi, I just changed the file and put it into a folder. Please let me know if the other files (config.yaml etc) also should be put into the folder or if I should rename anything. Thanks! |
Hey, a few notes:
|
Apologies, but due to an unforeseen issue, OpenFL tests are failing [ref]. Please hang on tight while we are coordinating a fix, and we will re-initiate the failing run automatically. |
Got it, I just modified the files as per your previous suggestions. |
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
==========================================
+ Coverage 94.71% 94.72% +0.01%
==========================================
Files 117 117
Lines 8253 8251 -2
==========================================
- Hits 7817 7816 -1
+ Misses 436 435 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #ISSUE_NUMBER
Proposed Changes
Checklist
CONTRIBUTING
guide.pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].