Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling for brain age model #710

Merged
merged 12 commits into from
Nov 14, 2023
Merged

Conversation

1Pravi
Copy link
Contributor

@1Pravi 1Pravi commented Aug 6, 2023

Hi Team,

This pull request improves the brainage() function in brain_age.py by adding error handling and sys.exit() for better reliability. The changes ensure the code handles errors gracefully and provides informative feedback to users.

Please review. Thanks.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati self-requested a review August 7, 2023 01:33
@sarthakpati
Copy link
Collaborator

Thank you for your interest in contributing to GaNDLF! 😄

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting minor syntactic changes.

GANDLF/models/brain_age.py Outdated Show resolved Hide resolved
GANDLF/models/brain_age.py Outdated Show resolved Hide resolved
@sarthakpati sarthakpati changed the title "Add error handling and sys.exit() in brain_age.py" Add error handling for brain age model Aug 7, 2023
1Pravi and others added 2 commits August 7, 2023 07:51
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
@1Pravi 1Pravi requested a review from sarthakpati August 7, 2023 02:56
Copy link
Contributor Author

@1Pravi 1Pravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sir i replaced

@1Pravi 1Pravi closed this Aug 7, 2023
@1Pravi 1Pravi reopened this Aug 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
@sarthakpati
Copy link
Collaborator

Great! I can give the approval once the CLA is signed.

@sarthakpati
Copy link
Collaborator

sarthakpati commented Aug 8, 2023

Hey, there is some issue with your branch, and it is showing 237 changed files:

image

Could you please ensure that the edits are to the brain age model file and nothing else? That should fix the conflict issues as well.

@sarthakpati
Copy link
Collaborator

Hi @1Pravi, have you already signed the CLA?

@sarthakpati
Copy link
Collaborator

Hi @1Pravi, have you already signed the CLA?

@sarthakpati
Copy link
Collaborator

Hi @1Pravi, have you already signed the CLA?

@1Pravi have you signed the CLA? We should be able to merge this PR once that's done.

auto-merge was automatically disabled November 14, 2023 03:24

Head branch was pushed to by a user without write access

@sarthakpati
Copy link
Collaborator

I am following up on the CLA (#736).

@mlcommons mlcommons unlocked this conversation Nov 14, 2023
@sarthakpati sarthakpati merged commit 87af776 into mlcommons:master Nov 14, 2023
15 of 17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants