Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unit testing data to the mlcommons storage #722

Conversation

sarthakpati
Copy link
Collaborator

Fixes #721

Proposed Changes

  • moving to use mlcommons storage instead of penn box

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@sarthakpati sarthakpati marked this pull request as draft October 27, 2023 18:57
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #722 (90af114) into master (b230e02) will increase coverage by 0.00%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #722   +/-   ##
=======================================
  Coverage   94.69%   94.69%           
=======================================
  Files         117      117           
  Lines        8219     8221    +2     
=======================================
+ Hits         7783     7785    +2     
  Misses        436      436           
Flag Coverage Δ
unittests 94.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
testing/test_full.py 99.15% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sarthakpati sarthakpati marked this pull request as ready for review October 27, 2023 20:20
@Geeks-Sid Geeks-Sid merged commit d099b7b into mlcommons:master Oct 30, 2023
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
@sarthakpati sarthakpati deleted the 721-move-unit-testing-data-to-the-mlcommons-storage branch October 30, 2023 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move unit testing data to the MLCommons Storage
2 participants