Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code issues reported by codacy #808

Merged
merged 9 commits into from
Mar 27, 2024
Merged

Fix code issues reported by codacy #808

merged 9 commits into from
Mar 27, 2024

Conversation

benmalef
Copy link
Contributor

@benmalef benmalef commented Mar 4, 2024

Fixes #800

Proposed Changes

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

Deleted unused imports os, pickle that are reported by codacy
Deleted the unused  "MSELoss" and "L1loss" imported from "torch.nn".
These are reported by codacy
Deleted (put in comments) the parameters_temp variable.
It is reported by codacy.
Copy link
Contributor

github-actions bot commented Mar 4, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.09%. Comparing base (b9557f6) to head (df9469e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #808      +/-   ##
==========================================
- Coverage   95.10%   95.09%   -0.01%     
==========================================
  Files         122      122              
  Lines        8347     8344       -3     
==========================================
- Hits         7938     7935       -3     
  Misses        409      409              
Flag Coverage Δ
unittests 95.09% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benmalef benmalef marked this pull request as draft March 4, 2024 10:30
@benmalef benmalef marked this pull request as ready for review March 4, 2024 10:31
sarthakpati
sarthakpati previously approved these changes Mar 5, 2024
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VukW
Copy link
Contributor

VukW commented Mar 26, 2024

pytest CI workfolw fails beause of new version of dicom-anonymizer just was published (1.0.11 -> 1.0.12) and it's not a 100% backward compatible.
Fix: #836

@sarthakpati
Copy link
Collaborator

pytest CI workfolw fails beause of new version of dicom-anonymizer just was published (1.0.11 -> 1.0.12) and it's not a 100% backward compatible. Fix: #836

Thanks!

I am guessing this PR also needs to be re-linted (after #832).

@benmalef
Copy link
Contributor Author

Can you check it? I have signed the MLCommons CLA.
cla

@sarthakpati
Copy link
Collaborator

Ah okay, seems like the CLA is now passing. There are issues with the other integration tests (unit tests and linting) which are preventing the merge.

@VukW VukW self-requested a review March 27, 2024 12:14
Copy link
Contributor

@VukW VukW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@VukW VukW merged commit 890f277 into mlcommons:master Mar 27, 2024
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix some code style issues reported by codacy
4 participants